Daniel Marbach comments

Results 167 comments of


                                            Daniel Marbach

Bump RabbitMQ.Client from 7.0.0-rc.11 to 7.0.0-rc.14 in /src

Thanks @lukebakken

Bump RabbitMQ.Client from 7.0.0-rc.11 to 7.0.0-rc.14 in /src

@bording this is ready. Passes all the tests even with the new key guard in the client. Please feel free to just push additional changes before squashing

Emit message handler time metric

I made a larger comment on the other PR I was pinged on that is based on the work here https://github.com/Particular/NServiceBus/pull/7064#issuecomment-2173060785

Should transport block TTBR from sending if there are other delivery constraints defined?

We figured this might be better suited as a capability in NServiceBus instead of the transport

Organize meters by feature

I like it. I would even go one step further and put them into the behaviors where they make most sense. Essentially moving them out of the OTEL metrics folder

Organize meters by feature

> When adding a new metric, no failing tests signal that metrics and meters are part of public API. The problem is that with no failing test, there isn't an...

Organize meters by feature

I think there is also assumption in this statement that there needs to be a single test that verifies all meters. That is not necessarily true. In a feature oriented...