splash icon indicating copy to clipboard operation
splash copied to clipboard

splash reader for phantom-hdf5 files

Open danieljprice opened this issue 5 years ago • 2 comments

this is needed, some work sitting in pull request

danieljprice avatar Feb 24 '20 04:02 danieljprice

submitted pull request #42 to merge updated hdf5-phantom branch into master.

Before approving pull request, it should be checked that reading phantom hdf5 dumps returns the same arrays as reading the phantom binary dump. e.g. pxyzu from GR is currently not being read

dliptai avatar Sep 02 '20 09:09 dliptai

see comments on #42, this code needs to be rewritten in c consistent with the other hdf5 readers in splash, and also needs to be written in a way that does not hard wire the dataset names in the hdf5 reader, so it does not need ongoing maintenance any time a new quantity is written by phantom. Sorry for not being clearer on requirements here in the first place.

danieljprice avatar Sep 03 '20 23:09 danieljprice