gulp-stylint
gulp-stylint copied to clipboard
danielhusar
Improvements to support newer stylint versions
Removed the read() override as I think it's no longer needed in newer stylint versions.
By leaving the original read() method, we can take advantage of new functions such as .stylintignore support.
Please review and apply this to your repository. (I'm using this package to lint my stylus files and I really need this fix :) ) Thank you!
@nki2 Seems reasonable, but this broke quite a few tests. Could you take a look at them?
@SimenB I checked these and I think these were already here before my PR. (I get the same errors on the master branch)
I fixed some of the broken tests that were due to changes made to Stylint since these test were written. Here's the status.
1) It should log zero units
=> Fixed by fixing the test.
2) It should not log if file is valid with custom options
=> Seems to be a Stylint issue, as Stylint is logging a warning requiring a semicolon after "body"
3) It should not log if file is valid with custom inline options
=> Same issue as #2
4) It should accept custom reporter
=> Fixed by fixing the test.
5) It should accept custom reporter with custom options
=> Kind of fixed it by fixing the test but I think we have an issue with stylint here,
I can't get to set reporterOptions in the configs...
However, I think I need to fix Stylint it self as well to fix 2) & 3).
Hmm, ok, thanks or the detective work! Could you open an issue on stylint itself?
The test changes looks fine (although you could use chalk.stripColor on the first one), but broken reporterOptions is not good.
Could you open a separate PR for just making master green again? After that we can look into dropping our read function, as per your original PR 😄
/cc @danielhusar