gulp-pleeease icon indicating copy to clipboard operation
gulp-pleeease copied to clipboard

Next release

Open iamvdo opened this issue 9 years ago • 4 comments

Hey!

I've just created a sourcemaps branch with many improvements about, well... sourcemaps, but not only:

  • dealing with multiple input files
  • dealing with preprocessors easily, since they are included in pleeease

I've also added more tests, and add some of them in the README.

Can you please review this branch, and give feedback ? It's the first time I contribute to a gulp plugin, so I may be wrong.

Thanks! :+1:

iamvdo avatar Mar 27 '15 17:03 iamvdo

Hey,

cheers. I might not get into this today, but I will definitely take a look during the weekend. You can create a PR from this branch, its easier to review :)

danielhusar avatar Mar 27 '15 17:03 danielhusar

I've created PR, but I've made (too?) many changes. :) Plus, tests fail. :/

iamvdo avatar Mar 27 '15 17:03 iamvdo

When I run gulp css, it looks like pxrem blows up. Here are my source files:

http://cl.ly/aQwK

pxrem-pleeeease-error

If you can't reproduce this, feel free to correct me.

adamjohnson avatar Mar 27 '15 17:03 adamjohnson

It was a pixrem bug. Fixed in 1.2.3. Now it works. :)

iamvdo avatar Mar 27 '15 22:03 iamvdo