python-betterproto

python-betterproto copied to clipboard

### Summary Improve compatibility in monorepo/Bazel usages, so that package path can be treated as native namespace packages ### What is the feature request for? The core library ### The...

chrisirhc

Handle typing collisions and add validation to a files module for overlaping declarations

1

## Summary This PR builds off of the work [here](https://github.com/danielgtaylor/python-betterproto/pull/581), addressing the issue I posted here: https://github.com/danielgtaylor/python-betterproto/issues/580. As mentioned by @scott-hendricks we encountered coliding imports when the k8s protos defined...

imcdo

Imports can conflity with typing types

2

### Summary K8s List type proto conflicts with the typing List type ### Reproduction Steps use https://github.com/kubernetes/kubernetes/blob/c6b5191c37f939d2d61e76de222a96ae5f5d9558/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/generated.proto#L456 and try to generate proto for it. ### Expected Results The List type...

imcdo

## Summary The Kubernetes protobuf library contains a top level `List` [object](https://github.com/kubernetes/apimachinery/blob/703232ea6da48aed7ac22260dabc6eac01aab896/pkg/api/meta/interfaces.go#L33), which collided with the `typing.List` import in the top of each file. This resulted in the following error...

scott-hendricks

Paths are not normalized to posix format on Windows

1

### Summary Paths are not normalized to posix format on Windows ### Reproduction Steps Call `protoc` with the betterpython out options with multiple files that depend on one another. Also...

EraYaN

`mypy --strict` fails with `Name "betterproto.ServiceStub" is not defined`

2

### Summary `mypy --strict` fails with `Name "betterproto.ServiceStub" is not defined` ### Reproduction Steps 1. Generate some gRPC files from some proto files 2. Run `mypy` on the generated code...

llucax

Invalid Enum member names which contain the Enum name

3

### Summary 2.0.0b7 breaks enums with underscores in field names ### Reproduction Steps Test proto definition, in `test.proto`: ```proto syntax = "proto3"; package hello; // Greeting represents a message you...

connorbrinton

Struct cannot be serialized anymore

6

### Summary `Struct().from_dict({'a':'a'}).SerializeToString()` raises `TypeError: string argument without an encoding` ### Reproduction Steps ``` from betterproto.lib.google.protobuf import Struct Struct().from_dict({'a':'a'}).SerializeToString() ``` ### Expected Results no exception raised and proper serialization bytes...

leonardgerardatomicmachinescom

## Summary Fixes #212 Made a PR cause I didn't want to lose this to the dusts of time ## Checklist - [ ] If code changes were made then...

Gobot1234

## Summary The badge always shows the build as failing, even if it is actually successful. This issue has been reported on https://github.com/actions/starter-workflows/issues/1525 , and the fix suggested on https://github.com/actions/starter-workflows/issues/1525#issuecomment-1763431305...

AdrienVannson