python-betterproto icon indicating copy to clipboard operation
python-betterproto copied to clipboard

fix: broken relative imports for proto output types generation

Open Dimitrioglo opened this issue 1 year ago • 12 comments

Summary

  • Fixed broken relative imports for output types generation
  • Added possibility to generate interfaces for folder containing subfolders of .proto files
  • Refactored get_directories to return only first-level directories
  • Covered with the tests case when imports can be not generated

Checklist

  • [x] If code changes were made then they have been tested.
    • [ ] I have updated the documentation to reflect the changes.
  • [x] This PR fixes an issue. #472 #441
  • [ ] This PR adds something new (e.g. new method or parameters).
    • [ ] This change has an associated test.
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

Dimitrioglo avatar Jan 31 '24 20:01 Dimitrioglo

Can you check please? @danielgtaylor, @Gobot1234

Dimitrioglo avatar Jan 31 '24 21:01 Dimitrioglo

Please can you add a test for this case?

Gobot1234 avatar Jan 31 '24 21:01 Gobot1234

Please can you add a test for this case?

Done, can you check?

@Gobot1234 @danielgtaylor

Dimitrioglo avatar Feb 17 '24 17:02 Dimitrioglo

@Gobot1234 Can you process with review?

Dimitrioglo avatar Feb 22 '24 17:02 Dimitrioglo

Please can you run the code through black

Gobot1234 avatar Feb 22 '24 17:02 Gobot1234

@Gobot1234 fixed pre-commit hooks issues

Dimitrioglo avatar Feb 23 '24 08:02 Dimitrioglo

@Gobot1234 is any chance this fix will be released in next weeks/month?

Dimitrioglo avatar Feb 28 '24 16:02 Dimitrioglo

@Gobot1234 , @danielgtaylor Any news guys?

Dimitrioglo avatar Mar 16 '24 09:03 Dimitrioglo

Not sure why linux CI is failing

Gobot1234 avatar Mar 23 '24 21:03 Gobot1234

Hi @danielgtaylor , i am also facing the broken relative imports issue. when can we merge this PR ?

mohd-saaduddin-ansari avatar May 27 '24 17:05 mohd-saaduddin-ansari

It will be merged when the CI is fixed

Gobot1234 avatar May 27 '24 20:05 Gobot1234