python-betterproto icon indicating copy to clipboard operation
python-betterproto copied to clipboard

Map enum int's into Enums redux

Open Gobot1234 opened this issue 4 years ago • 4 comments

A continuation of #273 containing a reimplementation of betterproto.Enum (with 3.11+ features) as an open set along with some tests for this.

Closes #291 Closes #157 Closes #169

Gobot1234 avatar Nov 29 '21 21:11 Gobot1234

This should be ready to go now

Gobot1234 avatar Dec 24 '21 13:12 Gobot1234

+1 to this, for the sake of resolving issue #157

joetopp avatar Jun 22 '22 20:06 joetopp

Not really sure why the install's failing other than it might just be time to drop 3.6?

Gobot1234 avatar Aug 31 '22 18:08 Gobot1234

Actually this is probably just cause poetry dropped 3.6 support

Gobot1234 avatar Sep 01 '22 23:09 Gobot1234

@danielgtaylor @kalzoo will this ever be merged or implemented from maintainers?

Current implementation makes no sense. Message enum field should have an appropriate type and not just int.

sataset avatar Dec 04 '22 20:12 sataset

Python 3.6 is already at its end of life anyways, and soon 3.7 will be too, so I don't think support for 3.6 should matter that much.

And people using this project, instead of Google's official Python implementation, are likely here because they want newer features, so I don't think most would care for 3.6 anyways.

MicaelJarniac avatar May 10 '23 16:05 MicaelJarniac

Is there any reason this PR is not merged?

dingxiong avatar Sep 07 '23 20:09 dingxiong

If it means anything to a (hopefully) future reviewer, I've been using it in prod for a couple months and it's been working flawlessly.

Run1e avatar Sep 10 '23 12:09 Run1e

Just saw this in my review queue, reading now

cetanu avatar Oct 16 '23 02:10 cetanu