jpeg-archive icon indicating copy to clipboard operation
jpeg-archive copied to clipboard
verified publisher icon danielgtaylor

Create a recompress library to embedding in other sources

Open pope opened this issue 7 years ago • 4 comments

This pull request splits out the recompression logic in jpeg-recompress.c into its own source file.

The reason I want to do this is I'm interested in building a Go app that will recompress JPEG files in-place and in parallel. I have a prototype of that working, but don't worry, that's not in this request. I know I could use jpeg-archive or just do a child execution of jpeg-recompress, but I wanted one deliverable binary.

In addition to extracting the library, I did the following:

  • Added *.exe to .gitignore.
  • Added .editorconfig file to ensure consistent use of spaces/tabs.
  • Updated Makefile to account to 64 bit builds of MozJPEG on Linux
  • Updated readFile signature to take a const char * to avoid unnecessary casting.

Testing

I've tested on 64bit Linux and Windows 10.

pope avatar Jan 11 '18 21:01 pope

BTW, the broken build is with just the GCC part and had an error message of "An error occurred while generating the build script.". So I think the build is OK. I'm not sure how to re-run the CI build again to be sure.

pope avatar Jan 17 '18 17:01 pope

Ping. Any thoughts on this?

pope avatar Feb 08 '18 17:02 pope

Re-ping :)

pope avatar Mar 14 '18 15:03 pope

FYI - this branch now includes #85 .

pope avatar Mar 19 '18 22:03 pope