volon
volon copied to clipboard
Fixing select text contrast on dark theme
At the moment the contrast of text on select fields on dark theme is quite low. I made a small update to use --color-text-tertiary to increase the contrast.
| Before | After |
|---|---|
@talentedunicorn is attempting to deploy a commit to the danielgolden's projects Team on Vercel.
A member of the Team first needs to authorize it.
Thanks for the contribution, @talentedunicorn!I think the best play here would be to make the dropdown itself support the built in dark mode. Would you be interested in implementing that?
Thanks for the contribution, @talentedunicorn!I think the best play here would be to make the dropdown itself support the built in dark mode. Would you be interested in implementing that?
Sure thing. Is there an example of a component currently using the built in dark mode?
Yes, most of the existing components do support it already. Here's an example: https://github.com/danielgolden/volon/blob/main/src/components/Button.vue