volon icon indicating copy to clipboard operation
volon copied to clipboard

Fixing select text contrast on dark theme

Open talentedunicorn opened this issue 1 year ago • 4 comments

At the moment the contrast of text on select fields on dark theme is quite low. I made a small update to use --color-text-tertiary to increase the contrast.

Before After
image image

talentedunicorn avatar May 16 '24 06:05 talentedunicorn

@talentedunicorn is attempting to deploy a commit to the danielgolden's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 16 '24 06:05 vercel[bot]

Thanks for the contribution, @talentedunicorn!I think the best play here would be to make the dropdown itself support the built in dark mode. Would you be interested in implementing that?

danielgolden avatar Jul 25 '24 23:07 danielgolden

Thanks for the contribution, @talentedunicorn!I think the best play here would be to make the dropdown itself support the built in dark mode. Would you be interested in implementing that?

Sure thing. Is there an example of a component currently using the built in dark mode?

talentedunicorn avatar Jul 26 '24 17:07 talentedunicorn

Yes, most of the existing components do support it already. Here's an example: https://github.com/danielgolden/volon/blob/main/src/components/Button.vue

danielgolden avatar Aug 26 '24 13:08 danielgolden