Daniel Cohen Gindi

Results 141 comments of Daniel Cohen Gindi

Here: https://github.com/mysql-net/MySqlConnector/blob/000f586ce78e7c858b697d6e3b94cfcc68ac3162/src/MySqlConnector/Protocol/Serialization/ProtocolUtility.cs#L434 We need to somehow test for an aborted/disconnected connection. Otherwise it goes on to throw that error.

> Are you essentially proposing that (in this scenario) the library throw a `MySqlException` (with appropriate `ErrorCode`) instead of an `EndOfStreamException`? It would be best if we can determine the...

After investigating Oracle's code, I found out that that damn tokenizer IS the reason that MySqlScript is required in the first place! If you want to `CREATE PROCEDURE` or `CREATE...

I'm talking about `MySql.Data` :-)

It's good for running scripts from sql files on disk or supplied by users, but that's a risky case anyway. And it could be solved by taking the tokenizer from...

@tofilagman Note that you'll have to initialize its properties (i.e `BackslashEscapes`) from the Mysql's MODE before usage, in order for that to be safe.

Interesting that after my issue being dismissed- the only issue that remains open is exactly a case of what I was talking about: https://github.com/icanzilb/EasyAnimation/issues/23

You have not actually changed the code, only `package.json`. You probably pushed the wrong branch.

It's just waiting for a merge!