Charts icon indicating copy to clipboard operation
Charts copied to clipboard

Fix Xcode 14 and Swift 5.7 compiler error

Open dangthaison91 opened this issue 2 years ago • 1 comments

https://github.com/danielgindi/Charts/pull/4823#issuecomment-1195361015

Issue Link :link:

Fix compilation error with Xcode 14 and Swift 5.7 #4863 #4870 #4838 #4835

Goals :soccer:

Implementation Details :construction:

This PR simply collect other fixes by several developers into one PR:

  • #4823
  • #4836
  • https://github.com/danielgindi/Charts/issues/4860#issuecomment-1178968435

Testing Details :mag:

dangthaison91 avatar Jul 26 '22 13:07 dangthaison91

I can confirm this patch PR works for xcode 14 beta 3&4

dingtianran avatar Jul 28 '22 01:07 dingtianran

A friendly ping to @pmairoldi to include this PR in the upcoming release! 🙏

crazymanish avatar Aug 10 '22 13:08 crazymanish

In case anyone is wondering, beta 5 will likely be very similar to the 14.0 GM or public version, so this (or #4881) would be ready to land or use in your local fork of Charts.

alanzeino avatar Aug 18 '22 21:08 alanzeino

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

waterskier2007 avatar Aug 23 '22 15:08 waterskier2007

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

Which crashes ? May you show gist ?

iDevPro avatar Aug 23 '22 15:08 iDevPro

Has anyone tested this on lower version of iOS such as 14.5? I am getting some crashes when applying this fix to my own fork.

@waterskier2007 I tried on 14.5, I don't see any crash so far

adityarajpt avatar Aug 24 '22 06:08 adityarajpt

On XCode 14.6 Beta I have errors :/

werkaflute avatar Aug 26 '22 09:08 werkaflute

Everything from this PR has been merged from other PRs. Thanks contributing!

pmairoldi avatar Aug 28 '22 00:08 pmairoldi

@pmairoldi @danielgindi When will there be a new release or tag with all the changes in master? Specifically the Xcode 14 support

nkark avatar Aug 30 '22 23:08 nkark

When Xcode 14 gm is released

pmairoldi avatar Aug 30 '22 23:08 pmairoldi

@pmairoldi @danielgindi When will there be a new release or tag with all the changes in master? Specifically the Xcode 14 support

change your package manager to point to the git commit and you don't need to wait for a new release or tag

alanzeino avatar Aug 31 '22 07:08 alanzeino

@danielgindi Is there a plan to change the package name so we can use Apple's Charting library?

PorterHoskins avatar Aug 31 '22 12:08 PorterHoskins