Charts icon indicating copy to clipboard operation
Charts copied to clipboard
verified publisher icon danielgindi

Add double mark for compiler check related with issue #4835

Open eliakorkmaz opened this issue 3 years ago • 5 comments

Issue Link :link:

https://github.com/danielgindi/Charts/issues/4835

in Xcode14 there is an compiler check error because of ambiguity of some math arithmetics, so this pr aim to fix it

Goals :soccer:

Because of this compiler error, i aim to fix this problem for xcode14-beta versions

Implementation Details :construction:

There are no architectural changes, I just put Double casting into magic number as 1.0

eliakorkmaz avatar Jun 08 '22 07:06 eliakorkmaz

lgtm

michalnowak061 avatar Jun 13 '22 14:06 michalnowak061

thank you @MichalMartinu , this pr is still open because of 1 workflow awaiting approval

eliakorkmaz avatar Jun 23 '22 12:06 eliakorkmaz

hey @MichalMartinu , a maintainer with write access may need to approve any workflow runs.

Can you give approve to workflow run?

eliakorkmaz avatar Jun 23 '22 15:06 eliakorkmaz

Hi @danielgindi, @pmairoldi, can you approve this PR to provide support for Xcode14(beta)? Thanks in advance!

lchamp avatar Jun 29 '22 13:06 lchamp

We usually do not support betas as things can change all the time. When Xcode 14 is GM we will release something if need be. Will keep this open for now.

pmairoldi avatar Jun 29 '22 14:06 pmairoldi

In Xcode 14 beta 6 I dont get this error anymore. Closing

pmairoldi avatar Aug 28 '22 00:08 pmairoldi

Actually never mind. The library compiles fine but this is needed to run in an app. Kinda weird.

pmairoldi avatar Aug 28 '22 00:08 pmairoldi

Thanks for the contribution!

pmairoldi avatar Aug 28 '22 00:08 pmairoldi

Thanks for the contribution!

@pmairoldi When can we expect a release with this fix?

michalnowak061 avatar Aug 29 '22 14:08 michalnowak061

I will wait until the Xcode 14 gm and if everything is still fine I’ll release a new version.

pmairoldi avatar Aug 29 '22 14:08 pmairoldi