Tag naming convention incompatible with SPM

[simonmcl]

ℹ Please fill out this template when filing an issue. All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.

Per our *CONTRIBUTING guidelines, we use GitHub for bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag ios-charts.

Please remove this line and everything above it before submitting.

• [x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

Tried to import a specific version through SPM

What did you expect to happen?

To be able to specify "4.0.1" or a range (e.g. 4.0.1 <= 4.9.9)

What happened instead?

Because the repo uses a naming convention on the tags, starting with a "v". SPM is unable to use the Version rules to import the package, as it expects only numerics. The result is requiring users to import the branch "master". This leaves projects open to getting breaking changes without notice. Or forces users to pick a specific commit

Please remove the "v" from your tag naming convention going forward. Thank you

[yasuradodo]

I second that 👍 If there is no v in tags, we can manage versions of this nice framework a little more easily with SwiftPM.

[pmairoldi]

I don't really get the problem. I just tried it and it works fine with the v, at least in Xcode. Am I missing anything?

[simonmcl]

@pmairoldi there must have been an update to Xcode to handle this case. It works now but didn't in the past. Entering 4.1.0 would give you an error message along the lines of "can't find a tag named 4.1.0"

I'd still recommend switching to semver format (dropping the leading v) to avoid such a thing happening with other tools

[pmairoldi]

I don’t see a problem with switching besides needing to change the podspec file to drop the ‘v’. I’ll leave this open so I remember next update.

[pmairoldi]

Close by https://github.com/danielgindi/Charts/releases/tag/5.0.0