workflow-core icon indicating copy to clipboard operation
workflow-core copied to clipboard

Published 20 hours ago • verified publisher icon danielgerlag

fix: #1344 convert destObj to the correct property type before settin…

Open nurlanmikayilov opened this issue 8 months ago • 3 comments

There is no longer a need to specify the input data type. A minor change for Issue #1344 now allows it to function without requiring data type information for the input.

nurlanmikayilov avatar Mar 28 '25 09:03 nurlanmikayilov

Thank you for this contribution. This is really great. Could you please add some test coverage for this scenario to the StoredJsonScenario integration test?

https://github.com/danielgerlag/workflow-core/blob/master/test/WorkflowCore.IntegrationTests/Scenarios/StoredJsonScenario.cs

danielgerlag avatar Mar 28 '25 18:03 danielgerlag

Thank you for this contribution. This is really great. Could you please add some test coverage for this scenario to the StoredJsonScenario integration test?

https://github.com/danielgerlag/workflow-core/blob/master/test/WorkflowCore.IntegrationTests/Scenarios/StoredJsonScenario.cs

I’ve added the requested integration tests. Let me know if any further changes are needed.

nurlanmikayilov avatar Mar 29 '25 07:03 nurlanmikayilov

Hi @danielgerla , I recently made a pull request and have since added a few more commits to support list of complex input type. Could you please review the latest changes when you have a moment? I’d appreciate your thoughts and any suggestions for further improvement. Thanks for your time!

nurlanmikayilov avatar Apr 16 '25 18:04 nurlanmikayilov