Supported Lineage build fails - surnia

[mannp]

I am unable to get a Motorola surnia build to work, while it appears to be a supported device;

https://github.com/danielfullmer/robotnix/tree/master/flavors/lineageos/lineage-18.1)/device-dirs.json

flake.nix

      robotnixConfigurations."surnia" = robotnix.lib.robotnixSystem ({ config, pkgs, ... }: {
        imports = [ common ];
        device = "surnia";
        variant = "eng";
        flavor = "lineageos";
        #androidVersion = 11;
      });

Error output

Which product would you like? [aosp_arm] lineage_surnia
In file included from build/make/core/config.mk:313:
In file included from build/make/core/envsetup.mk:312:
[1mbuild/make/core/product_config.mk:160: [31merror: [0m[1mCan not locate config makefile for product "lineage_surnia".[0m
11:09:27 dumpvars failed with: exit status 1
** Not a valid product: lineage_surnia

Device definition

  "device/motorola/surnia": {
    "date": "2021-03-20T07:05:33+00:00",
    "deepClone": false,
    "deps": [
      "device/motorola/msm8916-common"
    ],
    "fetchLFS": false,
    "fetchSubmodules": false,
    "leaveDotGit": false,
    "path": "/nix/store/p84pnbp4jqwszyqysxjk6wq590806xml-android_device_motorola_surnia",
    "rev": "625b09265e175f44f39f9c750ab1da5df1ab74a0",
    "sha256": "10sbsd264mpw7r03czzsj49ydigrppxjf5inrbkh95q3daqcfr48",
    "url": "https://github.com/LineageOS/android_device_motorola_surnia"
  },

  "device/motorola/msm8916-common": {
    "date": "2021-08-17T19:40:06+02:00",
    "deepClone": false,
    "deps": [
      "kernel/motorola/msm8916",
      "external/bson",
      "external/sony/boringssl-compat",
      "hardware/sony/timekeep",
      "system/qcom"
    ],
    "fetchLFS": false,
    "fetchSubmodules": false,
    "leaveDotGit": false,
    "path": "/nix/store/nhlvnqcgb3kwrwgkc5y4xf03wbgj897r-android_device_motorola_msm8916-common",
    "rev": "8d3144aeddf154b6bbca101de0ede16ebdc5d8ff",
    "sha256": "1xhwm1yzbkc1ww888pz56la22a37c1d4jv84cy3p5n2rx973aink",
    "url": "https://github.com/LineageOS/android_device_motorola_msm8916-common"
  },

Thanks.

[Atemu]

Why are you building for variant = "eng";? Try the default, I'm not sure LOS supports anything else.

What's in the common module?

[mannp]

It works for my own non-supported builds, but maybe does nothing.

Did I miss something from the docs that it is not supported?

Anyway, tried with and without it and with and without androidVersion = 11 and 12, none of them build.

Added msm8916-common to the original post and default log below;

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Build type choices are:
     1. release
     2. debug

Which would you like? [1] release


Which product would you like? [aosp_arm] lineage_surnia
In file included from build/make/core/config.mk:313:
In file included from build/make/core/envsetup.mk:312:
[1mbuild/make/core/product_config.mk:160: [31merror: [0m[1mCan not locate config makefile for product "lineage_surnia".[0m
12:51:06 dumpvars failed with: exit status 1
** Not a valid product: lineage_surnia


Variant choices are:
     1. user
     2. userdebug
     3. eng
Which would you like? [eng] userdebug

============================================
PLATFORM_VERSION_CODENAME=REL
PLATFORM_VERSION=12
TARGET_PRODUCT=aosp_arm
TARGET_BUILD_VARIANT=userdebug
TARGET_BUILD_TYPE=release
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
TARGET_CPU_VARIANT=generic
HOST_ARCH=x86_64
HOST_2ND_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-5.17.6-x86_64
HOST_CROSS_OS=windows
HOST_CROSS_ARCH=x86
HOST_CROSS_2ND_ARCH=x86_64
HOST_BUILD_TYPE=release
BUILD_ID=SP2A.220405.004
OUT_DIR=out
PRODUCT_SOONG_NAMESPACES=device/generic/goldfish device/generic/goldfish-opengl hardware/google/camera hardware/google/camera/devices/EmulatedCamera device/generic/goldfish device/generic/goldfish-opengl packages/apps/Bluetooth
============================================