smudge icon indicating copy to clipboard operation
smudge copied to clipboard

Image support

Open jkdufair opened this issue 4 years ago • 4 comments

@danielfm I thought this could be fun. Let me know what you think.

image

jkdufair avatar Feb 12 '21 20:02 jkdufair

Well this hack doesn't hold up very well to sorting, narrowing, widening etc. I'm gonna close this and mess around some more to find a possibly less hacky way to accomplish this.

jkdufair avatar Feb 13 '21 02:02 jkdufair

Hey @danielfm I got this pretty well working! Works for track and playlist search. I ended up putting the image in the left margin so it didn't jam up spacing of the actual table. Adds maybe 1-2 sec to include images. Not too noticeable. Wanna give it a look?

image

jkdufair avatar Apr 03 '21 06:04 jkdufair

I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images.

Do you agree?

danielfm avatar Apr 09 '21 22:04 danielfm

I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images.

Do you agree?

I do agree. There is a config but it defaults to true. Maybe defaulting to false is better. Or maybe default depending on terminal vs gui?

jkdufair avatar Apr 09 '21 22:04 jkdufair