multi-module-maven-release-plugin icon indicating copy to clipboard operation
multi-module-maven-release-plugin copied to clipboard

Allow external snapshots

Open Marx2 opened this issue 6 years ago • 5 comments

Hi My builds depend on springfox libraries, they're not crucial in production env, so I don't care that I use snapshots of release 3

Currently I get:

[ERROR] Cannot release with references to snapshot dependencies
[ERROR] The following dependency errors were found:
[ERROR]  * apps-service references dependency springfox-spring-webmvc ${springfox.version}

Maven release plugin support property: -DignoreSnapshots=true which allows to use snapshots dependencies during release cycle.

I would like to achieve similar behavior. Maybe (because of how MMMRP work) we can do sth different, like: -DuseSnapshot=springfox-spring-webmvc ? That settings would just use snapshot dependency of this library without touching anything about it.

Marx2 avatar Aug 05 '19 13:08 Marx2

I've tried to use -Darguments="-DignoreSnapshots=true" but it didn't help :(

Marx2 avatar Aug 06 '19 07:08 Marx2

Hello, I must admit I'm not enthusiastic about allowing snapshots at all in this comment, so I don't plan to have this feature sorry.

danielflower avatar Aug 10 '19 03:08 danielflower

It's supported by plain Maven release plugin, that's why I'm asking. On my local fork I've just commented out PomUpdater.java:122 error (replaced with just warning), and now it ignore such dependencies. I'm not 100% sure it's good method to achieve it, but it seems to work.

Marx2 avatar Aug 12 '19 06:08 Marx2

👍 for behaving like the Maven release plugin. I see nothing wrong with disallowing snapshot dependencies by default but offering to overrule that.

marcelstoer avatar Sep 19 '19 13:09 marcelstoer

@danielflower I can create a PR for this if this is something you are going to merge eventually.

kobynet avatar Mar 24 '22 15:03 kobynet