tlsprofiler icon indicating copy to clipboard operation
tlsprofiler copied to clipboard

Port Nassl/SSLyze to upstream

Open veehaitch opened this issue 5 years ago • 7 comments
trafficstars

Hey there! Thanks for this useful project.

Internally, TLS Profiler uses a fork of Nassl and SSLyze. Do you have any plans on bringing your extensions for TLS Profiler into upstream Nassl/SSLyze?

veehaitch avatar Jun 24 '20 07:06 veehaitch

Please allow me to draw your attention to this issue again, @danielfett and @fabian-hk. Thank you!

veehaitch avatar Jul 03 '20 19:07 veehaitch

Hey, sorry for the late reply. There are already pull requests submitted to nassl #58 and SSLyze #410 but the maintainer of these packages did not yet review them.

fabian-hk avatar Jul 04 '20 08:07 fabian-hk

No worries and thanks for your response!

Looks like those PRs have conflicts since they have been open for some time already. Would you be willing to rebase your changes for both PRs?

I'm currently working on bringing Tlsprofiler support to nixpkgs: https://github.com/NixOS/nixpkgs/pull/91380. To that end, it would be very useful to have the required Nassl/SSLyze feature available upstream. I guess, this would also ease Tlsprofiler packaging in a general sense.

Feel free to reach out if you need any support.

veehaitch avatar Jul 04 '20 08:07 veehaitch

I think the nassl branch should be easy to fix but the SSLyze part is probably a little bit more complicated. I will look into it.

fabian-hk avatar Jul 04 '20 08:07 fabian-hk

Thank you!

veehaitch avatar Jul 04 '20 08:07 veehaitch

up !

unl1k3ly avatar Aug 15 '20 23:08 unl1k3ly

@veehaitch @unl1k3ly I just wanted you to know that I have updated the TLSProfiler to support sslyze 3.1.0: PR #8. Sslyze 3.1.0 has the problem that it does not output the full server cipher suite order preference: Issue: #338. But this should be fixed in the next version 3.1.1.

fabian-hk avatar Dec 25 '20 14:12 fabian-hk