Daniel Fett

Results 32 issues of Daniel Fett

Complaints about missing SCTs should only be raised if the certificate was created after April 30, 2018.

The current description of the usage of SD-JWT in the PID rulebook is not sufficient to result in PID attestations that are compatible to existing conventions and standards like JWTs...

Mainly fixes #266 based on https://vcstuff.github.io/sd-jwt-vc-types/danielfett/fix-claims/draft-fett-oauth-sd-jwt-vc-types.html#section-8 Also Fixes #272 Also Fixes #271

do-not-merge

Right now, the definitions (e.g., [this](https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#name-credential-issuer-metadata-6)) for `claims`/`credentialSubject` in the credential format profiles are broken (as [pointed out](https://github.com/openid/OpenID4VCI/issues/57#issuecomment-1723533366) earlier). At least the following problems exist: * There is no way...

The draft in Sections 5 and 6 refers to the security BCP: > The Authorization Endpoint is used in the same manner as defined in [[RFC6749](https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#RFC6749)], taking into account the...

At the WG call right now, we decided to merge the terminology PR #155 first and then go through the document afterwards to check if all terms are used correctly.

_Originally posted by @danielfett in https://github.com/openid/OpenID4VCI/pull/65#discussion_r1372116662_ The relationship currently described is that in any issuance process, multiple "types" of credentials can be issued (*), and for each "type" there can...

priority
ready-for-PR
batch-deferred

The definition of the `mandatory` key in the claim display metadata in the format profiles in Appendix A seems to be incomplete for SD-JWT VC. The first two read: >...

clarification

Some of the references in Appendix A probably point to the wrong places. I think the ones marked in the following figure should be checked: ![Screenshot_20240219_133105](https://github.com/openid/OpenID4VCI/assets/89476/6c6cb4b1-18f3-48de-afbe-a0f9876a8095)

ready-for-PR
clarification

In the three format profiles described in Appendix A, the definitions for the `claims`/`credentialSubject` contents do not match (ignoring inherent differences due to one of them describing the ISO mdoc...