melon icon indicating copy to clipboard operation
melon copied to clipboard

Rename types.isClosure

Open daniele-rapagnani opened this issue 4 years ago • 3 comments

It's probably best to rename types.isClosure to types.isFunction. Even if they are called Closures by the VM they are Functions for the end-user.

daniele-rapagnani avatar Jan 07 '21 17:01 daniele-rapagnani

@daniele-rapagnani In which file does the issue lie?

Siddharth1010 avatar Jan 07 '21 18:01 Siddharth1010

Hey @Siddharth1010 , you can find it in types_module.c. It should be as simple as renaming it there and possibly in some of the unit tests, I suspect only in the ones pertaining to the types module itself.

daniele-rapagnani avatar Jan 07 '21 18:01 daniele-rapagnani

Hey @Siddharth1010! I was wondering if you still wanted to fix this issue? I'm working on another issue related to the types module, so I wanted to check. Cheers!

NathanGugel avatar Jan 12 '21 04:01 NathanGugel