Daniël de Kok

Results 135 comments of Daniël de Kok

> `set_persistent_activations` and maybe use the name "persistent" in other places as well? `set_persisted_activations` or maybe `set_saved_activations`?

> Isn't it more along the lines of `set_activations_to_store` or `set_activations_to_save` or `set_store_activations_setting`? Changed to `save_activations`. Since it can now only be enabled/disabled, it is a regular property again (no...

Note: tests are failing in MyPy because we need Thinc with https://github.com/explosion/thinc/pull/739.

> Please allow me to ask this :trollface: question. Isn't the `store_activations` mechanism kind of a temporary stand-in for a more general `GlobalListener` that is kinda like an `ActivationPool` that...

> I think we can now remove some of the commented out lines that reference the `v2` parser, seeing how we won't be porting it back to `spacy-legacy`? Removed all...

> When did you make the decision not to have legacy support for `spacy.TransitionParser.v1` and `spacy.TransitionParser.v2`? This is extremely breaking. First the idea was to bring back the older versions,...

> It's ugly, but does mean the old configs can still be used. I also imagine that the legacy parser would probably entail a lot more than just the one...

The minimum spanning tree decoder in the biaffine parser supports multiple heads, but the biaffine parser itself still needs to be more constrained to follow spaCy rules/conventions. When it comes...

Thanks for reporting this issue! We currently only support using a single GPU with `require_gpu(gpu_id=N)`, but multi-GPU support is on our todo list. Of course PRs to improve multi-GPU support...

Edit: sorry, posted a reply in the wrong issue.