Daniel Weeks
Daniel Weeks
> > Hi @danielcweeks that looks like a nice cleanup. But I have 2 concerns: > > 1. By pushing the config verification down to `ContentCache` constructor, that will make...
@rizaon Thanks for your contribution here and keeping this updated! I'm excited to see how this works out.
@jzhuge or @anjalinorwood I feel like I'm missing something in terms of where we actually access the view content / text? I would think that would live in `ViewRepresentation` or...
I think it would be good to discuss what the use case is for this. I can understand trying to annotate some additional information but I'm not sure that this...
> @jebnix I think the current docs are OK. @danielcweeks correct me if I'm wrong but there is no need for Hive Metastore when configuring Iceberg with the REST Catalog,...
@electrum I've updated to add the configuration for session info which defaults to `NONE` and there is a [PR](https://github.com/apache/iceberg/pull/6251) to clarify the REST behavior. Please take another look when you...
A few comments/questions, but overall looks good. You might want to double check all the access levels for classes as I think we're generally overexposing.
@steveloughran This looks really great! I think my only comment would be about wether we can expose the implementation in a way that might be more pluggable. In Iceberg we...
> Could you please clarify why using Coral does not work? Looks like it achieves points (1) and (2) in your original comment, in addition to fixing the correctness issues...
You might want to reach out to @savaki who contributed the docker container. It would also help to know where you're seeing these errors and provide more detail including stack...