Daniel Crisp

Results 23 comments of Daniel Crisp

It's been a while since I looked at this but I think the problem is the rounding here: ``` proposal = Math.round(proposal / per) * per; ``` https://github.com/danielcrisp/angular-rangeslider/blob/master/angular.rangeSlider.js#L579 Basically `step`...

You might need to listen for `touchmove` as well. Alternatively I think there is a way to temporarily disable the ion menu. So you could disable it on `touchstart` (within...

Amazing - thank you, will take a look soon

Wow thanks, some good PRs coming in today! I'll take a look soon

Have you tried using invisible borders? That's how I usually increase the 'hitbox' of an element... ``` css /* you can't just copy and paste this, its just an example...

Can you set up a fiddle please?

I've found that I can subscribe to the `onDestroy` observable of `DialogRef` inside my child component. Is that the correct way to do this? ```javascript this.dialogRef.onDestroy.subscribe(() => { // destroy...

A bit more investigation has shown this is causing memory leaks. You can see it happening here, on a small scale, with the Plunkr above: ![image](https://cloud.githubusercontent.com/assets/1104814/22825483/732e2356-ef85-11e6-9450-492eae7d5c9b.png) It's much more of...

Ahhhaaa progress... It seems I can call the `clear()` method on the `defaultViewContainer` object, then I see `ngOnDestroy` firing in my child component. ```javascript onClick() { // open the modal...

A side effect of this technique is that the close animation no longer occurs, because the contents are immediately destroyed. Perhaps if it was handled internally it could happen after...