Daniel Chalef

Results 181 comments of Daniel Chalef

@dev2049 Tests pushed Took me a little longer to get the tests written. I hadn't really thought very deeply what popping would do here in terms of testing expected vs...

Looks like github is having issues again :-( ``` Fetching the repository /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +03d2d1812795c619db355c36408497040e658203:refs/remotes/pull/4533/merge Error: fatal: unable to access 'https://github.com/hwchase17/langchain/': The...

My bad. Cut a small PR: https://github.com/hwchase17/langchain/pull/3242

I'm overriding `from_texts` in an incompatible manner having added additional arguments. How do you suggest I modify to pass the linter?

@dev2049 Modified per your suggestions. mypy is still unhappy with the method signature overrides: ``` langchain/vectorstores/supabase.py:95: error: Signature of "from_documents" incompatible with supertype "VectorStore" [override] langchain/vectorstores/supabase.py:95: note: Superclass: langchain/vectorstores/supabase.py:95: note:...

> note that base class VectorStore has default `from_documents` implementation that probably works for you use case Good catch. Thanks! mypy doesn't like my previous use of a keyword-only argument...

Create a table called "docstore" or modify the Postgres function to use the table name reflecting your schema. I'll cut a PR later to correct the example function.

Sounds like a great feature, though assumptions would need to be made around embedding model. I don't have bandwidth to work on this, but am sure the langchain team would...

The container images are only currently available for `amd64` and not `arm64`. Rosetta emulation is failing for `notlangchain/langchainplus:d01018146320` with the above error. Are there plans to build `arm64` containers?