rangeslider-videojs icon indicating copy to clipboard operation
rangeslider-videojs copied to clipboard

Rangeslider doesn't work with newer versions of minified videojs

Open wilsonwc opened this issue 10 years ago • 11 comments

It looks like newer minified versions of videojs are not compatible with rangeslider. This seems to be because of the plugin referencing internal variables like .options_. I will try to get a patch together in the next few days to fix the issue.

wilsonwc avatar Jun 01 '14 04:06 wilsonwc

It could be great if you fix it. Please let me know if you need anything

danielcebrian avatar Jun 04 '14 14:06 danielcebrian

Hi, first thanks for the plug in. Do you got any update for those compatibility issues with the minified versions of videojs?

tebanhdez avatar Aug 19 '14 22:08 tebanhdez

Not yet, but you could open an issue in videojs if you like

danielcebrian avatar Aug 21 '14 11:08 danielcebrian

I just tried with newest minified version of videojs (4.9.1) and so far I have seen that these things are not comptaible any more:

videojs.SeekBar.prototype.options_ - has been renamed to videojs.ControlBar.prototype.l in minified version videojs.ControlBar.prototype.options_ - has been renamed to videojs.ControlBar.prototype.l in minified version videojs.blockTextSelection() - doesnt exist any more videojs.formatTime() - doesnt exist any more videojs.removeClass() - doesnt exist any more

papoola avatar Oct 24 '14 09:10 papoola

I tried for two hours debugging and changing code of rangeslider to make it compatible with minified and obfuscation version of video.js. Unfortunately at some point I gave up, as I lacked understanding behind parts of code. I think @danielcebrian should have look at this modified code whenever he has got some time and see whats missing https://github.com/papoola/rangeslider-videojs/compare/obfuscated-videojs-compatible

@nobe4 best thing you can do at the moment (which I did as well) is to go to http://refresh-sf.com/yui/ and copy/paste unminified version of video.js and check option Minify only, no symbol obfuscation. and this way create your own minified version of video.js which does work with rangeslider.

papoola avatar Nov 17 '14 09:11 papoola

Has anyone made in progress on this? @wilsonwc, were you able to patch this? If not, I'm going to spend some time looking at this issue.

rsadwick avatar Feb 21 '15 17:02 rsadwick

Hello Guys, Is the issue resolved? I am still not able to use range slider plugin with video.js @danielcebrian Can you please help us in it?

harishsalian05 avatar Mar 30 '15 12:03 harishsalian05

@harishsalian05 if you follow my instructions you can get it to work with a customized minified version of video.js

papoola avatar Mar 30 '15 14:03 papoola

Thank you @papoola for the answer and sorry guys but I am still stuck in solving this. The solution could be to modify the videojs compilator

danielcebrian avatar Apr 05 '15 12:04 danielcebrian

Is there any progress on this issue?

tessact avatar Jan 24 '17 12:01 tessact

I am on different project and I am so sorry but I could no mantain this project for now. If you want to try, I am happy to help you.

danielcebrian avatar Jan 24 '17 16:01 danielcebrian