react-360-keyboard icon indicating copy to clipboard operation
react-360-keyboard copied to clipboard

prevent the keyboard follow the camera

Open horacioh opened this issue 7 years ago • 2 comments

solves #1

I don't know if moving the keyboard is a usecase some people want (i Don't) but if so, I think a better solution would be to setup the keyboard position as a parameter when initializing the keyboard.

what do you think?

horacioh avatar Oct 17 '18 22:10 horacioh

Hey, thanks so much for the PR! The problem I see with your implementation is that the keyboard is always shown in the same position, no matter where I am currently looking. This might cause the keyboard to show up behind me.

A possible solution would be to set the surface's angle once, when the keyboard is shown, and then not update afterwards.

danielbuechele avatar Oct 18 '18 23:10 danielbuechele

ok that sounds reasonable!. in my testing with the oculus that did not happend, but I guess its better to go safe and calculate it just once.

let me change that!

horacioh avatar Oct 21 '18 18:10 horacioh