number icon indicating copy to clipboard operation
number copied to clipboard

Published 20 hours ago • verified publisher icon danielberkompas

If you use application config this library breaks in mix release on 1.9

Open Adzz opened this issue 5 years ago • 2 comments

I think it would be worth removing the ability to configure through Application config, as it should be discouraged (that's not what application config is for) and it currently wont work if you use mix releases in 1.9 because of this bug: https://github.com/elixir-lang/elixir/issues/9225

I'd be happy to make a PR, would have to be a major update though, as it will be breaking for people who are using application config.

Adzz avatar Jul 16 '19 12:07 Adzz

How would you suggest doing config for a library like this? It doesn't seem like you should need to run a process in your supervision tree to be able to use a library like this.

danielberkompas avatar Jul 31 '19 22:07 danielberkompas

I would suggest no config and have the config be runtime arguments or options to the given function.

Adzz avatar Aug 01 '19 08:08 Adzz