elasticsearch-elixir icon indicating copy to clipboard operation
elasticsearch-elixir copied to clipboard

Support runtime configuration via {:system, _} tuple

Open ImmaculatePine opened this issue 5 years ago • 1 comments

Currently it is not obvious that one can override MyApp.Cluster.init/1 for runtime configuration unless you read the source code. So, I did 2 changes there:

  1. Added support for more idiomatic {:system, _} tuple
  2. Added description of both configuration methods to readme

ImmaculatePine avatar Aug 11 '19 19:08 ImmaculatePine

Added support for more idiomatic {:system, _} tuple System tuples are heavily frowned upon

christianjgreen avatar Apr 01 '20 12:04 christianjgreen

I would prefer to just document that you can use MyApp.Cluster.init for this, rather than support {:system, _} tuples at this point.

danielberkompas avatar Oct 01 '22 13:10 danielberkompas