elasticsearch-elixir icon indicating copy to clipboard operation
elasticsearch-elixir copied to clipboard

Update bulk.ex with no types

Open mrnovalles opened this issue 1 year ago • 2 comments

ElasticSearch 7.x [1] already described the removal of mapping types. For the case of bulk endpoints:

Types should also no longer appear in the body of requests. The following example of bulk indexing omits the type both in the URL, and in the individual bulk commands:

[1] https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html

This commit removes the /_doc/ part of the URL when making Bulk uploads as part of the hot_swap_index function.

Fixes https://github.com/danielberkompas/elasticsearch-elixir/issues/113

mrnovalles avatar Oct 17 '23 08:10 mrnovalles

@danielberkompas Can we merge this in somewhat urgently? Elasticsearch is already at 8.12, and removal of /_doc imho is a change that is due. On a bit of a selfish note I need this at my job ;)

For those that need to use the current url suffix can just use the older version of :elasticsearch.

lovebes avatar Jan 19 '24 15:01 lovebes

Actually https://github.com/danielberkompas/elasticsearch-elixir/pull/106 might be a better approach I think.

lovebes avatar Jan 19 '24 15:01 lovebes