Daniel Bankhead
Daniel Bankhead
Today, we don't have a clean way to change AuthClient scopes uniformly between instances, and different AuthClients offer varying functionality like this: https://github.com/googleapis/google-auth-library-nodejs/blob/6c0a6bdc156c1098b09e85e82cabadaa73e7367f/src/auth/jwtclient.ts#L100-L115 We should offer a uniform API for...
We should normalize `GoogleAuth` to `GoogleAuth` (and `GoogleAuthOptions` as well). Additionally, we should: - change `clientOptions` from: https://github.com/googleapis/google-auth-library-nodejs/blob/4f94ffe474ee41b560813b81e8d621be848d38d0/src/auth/googleauth.ts#L106-L114 to: ```ts /** * Options object passed to the constructor of the...
It was moved to `AuthClient` as of: - https://github.com/googleapis/google-auth-library-nodejs/pull/1663
Today, some `AuthClient`s have a `scopes` property with of `string | string[]`: https://github.com/googleapis/google-auth-library-nodejs/blob/4f94ffe474ee41b560813b81e8d621be848d38d0/src/auth/baseexternalclient.ts#L140-L145 And we have to normalize in other places like this with code like this: https://github.com/googleapis/google-auth-library-nodejs/blob/4f94ffe474ee41b560813b81e8d621be848d38d0/src/auth/computeclient.ts#L51-L55 This is...
It's pretty legacy at this point and we can clean up this unnecessary code. https://github.com/googleapis/google-auth-library-nodejs/blob/5f296c37390ba71aa3aa1e4259ff7c525eeaad7c/src/options.ts#L20-L32
`jws` hasn't been maintained for 4+ years - we should migrate to another JWT library. Here's a nice list: https://jwt.io/libraries - [`jose`](https://npmjs.com/package/jose) looks solid Also consider compatibility and any significant...
This is a public tracking issue for alternate runtime support of this library.
Remove `reauth` Custom Error Handling introduced in https://github.com/googleapis/google-auth-library-nodejs/pull/1457/ after gRPC clients directly expose auth-related errors.
Revert PR https://github.com/googleapis/google-auth-library-nodejs/pull/1511 once https://github.com/JustinBeckwith/linkinator-action/issues/148 is resolved.
Un-revert https://github.com/google/gts/pull/808 and set `no-floating-promises` to `error` Context: - https://github.com/google/gts/pull/756#issuecomment-1714363976 Dependency: - https://github.com/googleapis/synthtool/pull/1877