Daniel Bankhead

Results 92 comments of Daniel Bankhead

Thanks @Dhoni77; note that this will require us to Node 16 (next stable), which will not happen for some time.

@leahecole yep! We will want to migrate away from both `retry-request` and `teeny-request` to `gaxios`.

It appears the `google-auth-library` is outdated, please update it to the latest version (9.10.0 or later).

I see, the auth parameter wants a `GoogleAuth` instance rather than an `AuthClient`. This should work: ```ts import { PubSub } from "@google-cloud/pubsub"; import { GoogleAuth, OAuth2Client } from "google-auth-library";...

Actually, this functionality is currently available via the `authClient` parameter.

It appears we have 2 networking libraries in the `fallback: 'rest'` path: - google-auth-library - node-fetch `google-auth-library` currently has retries for the ECONNRESET concern, however the `node-fetch` path does not....

@HubertJan thanks! We'll merge it in the next major

Thanks! > At the moment, only `GetAccessTokenResponse` and `Headers` are directly imported from oauth2client. Today, only those two types should be moved. As this functionality will not be released until...

We should just get rid of this dependency. This has broken us a number of times (as it incorporates breaking changes in patch releases) and its unclear who actually uses...