Daniel Bankhead

Results 92 comments of Daniel Bankhead

This library has been published in the [google-cloud-node](https://github.com/googleapis/google-cloud-node/) repo. It can be installed via [`npm i @google-cloud/procurement`](https://www.npmjs.com/package/@google-cloud/procurement). Source: - https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-commerce-consumer-procurement

Extracted error message: ```xml expected 'GaxiosError: Invalid response body wh…' to match /DNS Info:/ AssertionError: expected 'GaxiosError: Invalid response body wh…' to match /DNS Info:/ at Context. (test/externalclient.test.js:293:12) at processTicksAndRejections...

Added some additional output for debugging: - https://github.com/googleapis/google-auth-library-nodejs/pull/1760 Closing for now, expecting it to be reopened with additional details.

Hey @milinddethe15, good question - after #1663 has been merged the `RefreshOptions` interface itself can be removed.

@milinddethe15 done! Take your time as this refactor is a breaking change and we won’t release another major for some time.

@NewtonFernandis Absolutely, take your time as we won't be able to merge this fix until the library's next major release (likely sometime next year).

Note: the `!` in the title is important. See: https://www.conventionalcommits.org/

`do not merge` added until internal proposal has been approved.

This would introduce more complexity than is required to solve this problem; instead, we should encourage dependencies to expose their version of `google-auth-library` so that customers can have a guaranteed,...