Daniel Bankhead

Results 92 comments of Daniel Bankhead

What makes this PR breaking? It seems it can work without breaking existing users.

> > > What makes this PR breaking? It seems it can work without breaking existing users. > > On a previous PR, @bcoe was saying this should be a...

Fixed in https://github.com/googleapis/google-auth-library-nodejs/pull/1436

Fixed in https://github.com/googleapis/gaxios/pull/552

I think these are valid use cases, especially if customers know what they're doing. In some cases, a customer may only have an access token without a refresh token [[1]]...

Great question - if you're looking to retrieve the email I would recommend calling via [`gcp-metadata`](https://github.com/googleapis/gcp-metadata/#access-nested-properties-with-the-relative-path): ```ts const email = await gcpMetadata.instance('service-accounts/default/email'); ``` Additionally, `'default'` is sufficient for calling the...

> I understand that I could resolve the child_process module in Webpack to false or something else, but that seems like the wrong fix in this case since I actually...

Hey folks - we're working on improving support for this library on Electron. For now I'll remove this confusing documentation. Additionally, if you don't want to spin up a separate...

Here's a public tracking issue: - https://github.com/googleapis/google-auth-library-nodejs/issues/1638 I've closed this via #1635 as outdated documentation was the original issue. In the meantime we're actively working on alternate runtime support.