Daniel Bankhead

Results 92 comments of Daniel Bankhead

Here are a few options worth exploring: - https://developer.mozilla.org/en-US/docs/Glossary/Deep_copy - https://developer.mozilla.org/en-US/docs/Web/API/structuredClone

Hey @jpambrun, we've recently refactored our streams in a recent release (v6.4.1): - https://github.com/googleapis/nodejs-storage/compare/v6.4.0...v6.4.1 In short, we've removed `pumpify` (and the associated `.pipe`) & started using the native Node.js `pipeline`....

> I just moved the same code: [GoogleCloudPlatform/nodejs-docs-samples#2759](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/2759) > @danielbankhead could you please also approve? really appreciate I like these here for integration purposes, say an unexpected breaking change was...

Good to see you again @JustinBeckwith! We'll have to verify the permissions for the GitHub Actions before merging this PR: - https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Hey @hiranya911 - I'll pick this up for you (a few years after the fact 😅). You are correct, `projectId` is not required for this request (in fact, adding a...

As a note - I think this is a worth-while change, but would be backwards-incompatible as `Transporter` does not have `static USER_AGENT` and the `configure` method (which are public for...

A bit swamped - can't get to this anytime soon. I'll release this issue in case someone else has some bandwidth

Hey @m0ar, @salrashid123, & @FrodoTheTrue: found some time to work on this today. Here's the PR: - https://github.com/googleapis/google-auth-library-nodejs/pull/1439 It should be merged shortly after review 👌🏽

Want to give an update to this issue - this PR should resolve this issue, however we're syncing internally on its implementation and uniformity across languages: https://github.com/googleapis/gcp-metadata/pull/528

Idea: we can remove these files altogether if we want by moving the config to `package.json` (bonus: makes the base directory smaller): Ex: https://github.com/danielbankhead/picture-playlist/blob/main/package.json