Daniel Bankhead

Results 92 comments of Daniel Bankhead

Hey @neilstuartcraig - could you provide a sample that replicates the issue and any additional associated logs?

Hey @neilstuartcraig, after extensive debugging I'm unable to reproduce this error. Here's a working sample with a variety of test scenarios: ```ts import gunzipMaybe = require('gunzip-maybe'); import {Storage} from '@google-cloud/storage';...

Hey @neilstuartcraig, do you have any other information that would help us debug this issue for you? Since my last message, I expanded the test cases and verified a number...

A diff link for reference: https://github.com/googleapis/nodejs-storage/compare/v6.4.0...v6.4.1

Thanks! And no problem - no need to share source code or sensitive information 🙂 Other places to check: - Did any other dependencies in your dependency change between the...

A few other places to check: - How are the objects uploaded? Is it possible somehow some objects were legitimately gzipped incorrectly (and we're looking at a symptom of another...

Thanks for the additional information @neilstuartcraig, I believe https://github.com/googleapis/nodejs-storage/issues/2055 is related to the issue you are facing. I will do some more digging and resolve this for you.

Hey @neilstuartcraig, thanks for your patience - we were finally able to reproduce the issue and a fix has been merged. The next release will public shortly: - https://github.com/googleapis/nodejs-storage/pull/2050 To...

Implementation idea if we decide to adopt this - this could be a static method on `File`, say `File.from`: ```ts class File { static from (publicUrl: string | URL, options:...

Additional implementation note: should support `gs:` URIs as well to satisfy this feature request: - https://github.com/googleapis/nodejs-storage/issues/2057