Dan Allan

Results 756 comments of Dan Allan

Would it be too annoying to returning `False` and also _warn_? (Or maybe the underlying threading client will do that already, without any new effort?)

I think this is worth "fixing" to make our compat shim more compliant. Any chance you can throw a PR at it, @teddyrendahl?

Note to Future Me or anyone else: I think the most fruitful place to push would be to resolve the dangling threads and sockets left after each test. We have...

Thanks for the report and the kind words, @pklaus. We hadn’t noticed this. Fix in progress....

Ha. Looks like, “We hadn’t noticed this,” should have been, “I, Dan, completely forgot about this.” :-D In any case, this is on my docket.

Thanks for volunteering. Yes, let me write up what needs to be done....

Some context: The benchmarks are (well, I guess, _were_) generated using the project [asv](https://asv.readthedocs.io/en/stable/), a tool for measuring and publishing a project's benchmarks over its commit history in a variety...

## Optimizing for "set" over "get" Python's built-in `property` optimizes for getters: ```py @property def x(self): # Custom getter behavior ``` and provides a way to add a setter when...

P.S. I agree that claiming `pv` might mean that people refactoring to use it have to rename a local here and there, but I'm still in favor of it. This...