Daniel Bachhuber

Results 456 comments of Daniel Bachhuber

Assuming this has since been fixed up. Feel free to stop by the `#cli` channel on [WordPress.org Slack](https://make.wordpress.org/chat/) if you'd like help debugging further.

Feel free to stop by the `#cli` channel on [WordPress.org Slack](https://make.wordpress.org/chat/) if you'd like help debugging further.

Related https://github.com/wp-cli/extension-command/issues/159

I'm open to either changing the default behavior, or introducing a `--skip-vcs` flag to maintain backwards compatibility. It would be good to parallel whatever core does in this regard (I...

`wp plugin update --exclude=elementor --all` seems to work just fine for me

This sounds like a good idea! Feel free to submit a pull request, if you'd like. Here is some [guidance on our pull request best practices](https://make.wordpress.org/cli/handbook/contributions/pull-requests/).

> Would be much more helpful if it at least said once which plugin it is updating in a separate line first. I agree!

I think it would still be nice to indicate the plugin in the log output, e.g.: ``` $ wp plugin update --all Enabling Maintenance mode... Updating akismet Downloading update from...

@baizmandesign Thanks for diving into it! > The previous comments say that we need to extend Plugin_Upgrader and over-ride upgrade_strings() and install_strings(). It was also necessary for me to over-ride...

@baizmandesign It looks like this `before()` method is called roughly when we'd like it to: https://github.com/WordPress/wordpress-develop/blob/ee5142efbca11450e7befd202d37eba4660173c1/src/wp-admin/includes/class-wp-upgrader.php#L812 We can render whatever output we'd like in our custom `UpgraderSkin`: https://github.com/wp-cli/wp-cli/blob/52751b1d1f8bdf0b47d38942ec199c7840ee1d85/php/WP_CLI/UpgraderSkin.php#L13 If that...