blipp icon indicating copy to clipboard operation
blipp copied to clipboard

Add excluded option

Open woolfi182 opened this issue 5 years ago • 6 comments

woolfi182 avatar Oct 20 '18 00:10 woolfi182

@woolfi182 sorry for the delay. Can we change it to "exclude" as opposed to "excluded" ?

danielb2 avatar Nov 12 '18 18:11 danielb2

Sure:)

woolfi182 avatar Nov 12 '18 19:11 woolfi182

Who will do that? I don't have enough time to do that now. Probably, you have some

woolfi182 avatar Nov 12 '18 19:11 woolfi182

Travis CI cannot pass npm test for node v11 because of the experimental functionality: globals_queuemicrotask which is added to global scope, so, lab.js test framework recognize the new variable queuemicrotask as memory leak. there are two ways to solve that:

  • merge anyway
  • add exclude param to lab invocation What do you think about that?

woolfi182 avatar Nov 13 '18 18:11 woolfi182

In the package.json, add -I queueMicrotask argument to the lab command. That will solve the issue :)

danielb2 avatar Nov 15 '18 16:11 danielb2

@woolfi182 I wonder if it will also be valuable to use pattern matching to exclude multiple routes. For example '/assets/*'

danielb2 avatar Nov 20 '18 17:11 danielb2