DACircularProgress
DACircularProgress copied to clipboard
Progress jumps in 2.3
Animation jumps if animation is not completed yet and we set new progress value. Even incorrect value can be set, like in mentioned above example: self.progressView.setProgress(1.0, animated: true) //....and when I call during animation progress self.progressView.setProgress(0.5, animated: false) last call initiates remove of animation. And it calls animationDidStop delegate method asynchronously, even after proper progress is set. So after 0.5 is set, 1.0 will be set in animationDidStop in a moment
Version 2.2 without animation delegate works fine
i can confirm that
Look like this change broke that:
a7f53525b8250e8a416e055c2f29e9b622f4a8f1
The issue is that this bit of code was moved inside the else and not executed in the animated block:
-
self.circularProgressLayer.progress = pinnedProgress;
Moving it out of the else again fixes the issue.
+1
hi guys! FYI hi tried to make that change but didn't work, but I manage to solve it, look the PR: https://github.com/danielamitay/DACircularProgress/pull/67
hope it helps.
BTW, sometimes animations don't work at all, but I don't know exactly when and so why, because any of the progress views in the app work, so maybe is related somehow w/ the network layer... but I would say it started to happen when updated to >= 2.3