Daniela Brozzoni

Wallet::get_descriptor_for_keychain should return an Option

1

https://github.com/bitcoindevkit/bdk/blob/2c324d3759aed4548269084327c94ce91e7b386a/crates/bdk/src/wallet/mod.rs#L1993-L1997 In `Wallet::get_descriptor_for_keychain(keychain)`, if a user passes in a non-existent keychain, we instead return the descriptor associated with `KeychainKind::External`. What's the reason behind this behavior? IMHO we should just return...

User should have a way to know that a transaction changed its state

3

Right now if users want to know if a transaction was removed from the chain, or dropped from the mempool, they need to compare two versions of `list_unspent` obtained in...

ci should build the example_crates

1

Otherwise we might merge code that doesn't build. See https://github.com/bitcoindevkit/bdk/pull/1358

Expand the `KeychainTxOutIndex::inner` docs to provide usage examples

2

See https://github.com/bitcoindevkit/bdk/pull/1203#discussion_r1491860268

[wallet] Consider having a higher-level method for syncing

5

Looking at wallet_esplora or wallet_electrum, syncing takes quite a bit of code, and I suppose than 99% of users will just want to update the whole wallet in one big...

KeychainTxOutIndex method should behave consistently when non-existent keychains are passed in as arguments

2

Some KeychainTxOutIndex methods panic if a non-existent keychain is passed in as an argument. Some examples include: - `unbounded_spk_iter` - `next_index` Instead, the methods that return an iterator simply return...

Rename electrum's sync/scan

8

We can probably have more descriptive names, and that make it easier to distinguish between them (I keep confusing them, maybe it's just me). I don't have any proposal in...

Merge `tx_data_traits.rs` into `chain_data.rs`.

8

Remove the `tx_data_traits.rs` file and move all of it's contents into `chain_data.rs`. Also move the `Balance` struct into `chain_data.rs`. See https://discord.com/channels/753336465005608961/753367451319926827/1161983570538147932

trezor emulator: can't set up the device

11

Hey, I'm trying to set up a trezor emulator using this command: ``` ❯ hwi --device-type trezor -i setup ``` The emulator prompts me with a "Enter new pin" screen...