Daniela Baron
Daniela Baron
That `combine!` method got introduced from this 2017 PR: https://github.com/rubyforgood/human-essentials/pull/137 Although that was a refactor so maybe the logic was there from even earlier than that.
I'm still working on this, discussion has moved to the first attempt PR, and I'm WIP on the second solution: https://github.com/rubyforgood/human-essentials/pull/4341#issuecomment-2105745006
I'd like to attempt this one. Just trying to reproduce it now. Is there a user guide? I was trying to figure out how to add an item to a...
I'm able to reproduce the issue, by starting from a seeded/fixture dev db that has two storage locations with many items, then adding a new storage location, adding one new...
Took a look at the distribution export, that uses `app/services/exports/export_distributions_csv_service.rb` instead of `generate_csv` from the exportable concern. The key to it seems to be that it gets all items for...
Just an observation, I wondered why there wasn't a test failing due to this bug. Turns out there is a test for the storage locations csv export `spec/requests/storage_locations_requests_spec.rb` in csv...
Another thought re: validation, [ActiveModel](https://guides.rubyonrails.org/active_model_basics.html) can be used to create an abstraction of the data to be collected at each step/card, then validate just that part at that step. The...
I could pick this up if it's still available?
Absolutely I could pick up #3052 first.
Would it be possible to publish this to maven central?