Daniel Schreiber comments

Repositories
Issues
Comments

Results 64 comments of


                                            Daniel Schreiber

Added support for image download; Removed the file name trimming

Hi @license2e , thank you very much for contributing!! I have just some two remarks before merge: - The collecction of the images should be refactored from `HumanFormat.php`to `podio_backup_full_cli.php` -...

Added support for image download; Removed the file name trimming

Hi @aseques - you are very welcome to elaborate on the missing bits (see my comment) - then I'll happily merge!

Create missing output directories if not present

@ctaepper Thanks for this request! Would you like to make a PR for this?

SchematicTestRunner.runExternalSchematic fails with "The encoded data was not valid for encoding utf-8"

@alan-agius4 thanks for the pointers! It would be great if this could be adressed, as this breaks unit tests of schematics with jest and probably impacts some libraries..