Daniel Schreiber comments

Results 77 comments of


                                            Daniel Schreiber

Added support for image download; Removed the file name trimming

Hi @license2e , thank you very much for contributing!! I have just some two remarks before merge: - The collecction of the images should be refactored from `HumanFormat.php`to `podio_backup_full_cli.php` -...

Added support for image download; Removed the file name trimming

Hi @aseques - you are very welcome to elaborate on the missing bits (see my comment) - then I'll happily merge!

Create missing output directories if not present

@ctaepper Thanks for this request! Would you like to make a PR for this?

SchematicTestRunner.runExternalSchematic fails with "The encoded data was not valid for encoding utf-8"

@alan-agius4 thanks for the pointers! It would be great if this could be adressed, as this breaks unit tests of schematics with jest and probably impacts some libraries..

[Bug] The --exclude-file value is interpreted as the file content instead of the file path

@emarbo Thanks for this detailed issue. It looks like your analysis is correct. Would you like to make a PR? 😊

BUG: MongoDB missing type support / changes field type on update

This problem makes this tool rather useless for working with MongoDB (except for read-only or trivial update cases..). Is this something that can/will be fixed, or would this be a...

Feature: new sort option "contextAsc"

hi @aberonni this seems like a meaningful enhancement! Would you like to give it a shot and create a PR? Remarks: * probably it should validate that the context is...

No redirects are processed correctly in shell-to-batch conversion.

@rburkey2005 would you like to give it a try and make a PR?

self closing tags with newTranslationTargetsBlank

Hi @10eputzen this will probably be a little difficult to implement, as the serialization relies on https://github.com/nfarina/xmldoc which has no configuration for this. Probably some post processing with regex/search-replace could...

self closing tags with newTranslationTargetsBlank

@10eputzen fyi: in the latest release, this changed back to the original behaviour - to enable it again you need to explicitly set the option `selfClosingEmptyTargets: false`.