Daniel Falk

Results 34 comments of Daniel Falk

Thanks for positive feedback! Pushed a new commit with updated RELEASE file.

First, let me just make sure I understand what cases would work and what would not. In this image, number 1 and 3 would be OK, not 2 and 4?...

I see, I was wrong above stating that this ``` ds.is_good[:] = (ds.classes.numpy() == 1) | (ds.classes.numpy() == 2) ``` would prevent correct merging. The IDs are never changed when...

What is the status of this PR? Should I rebase it to latest mater?

Actually seems like if this issue has been solved by 3a9400b67? It does not seem like if I can reproduce it anymore :+1:

...perhaps not. I can still reproduce it if I try to load a dataset from an S3 bucket and there are no credentials configured: ``` python -c "import deeplake; deeplake.load('s3://fixedit-dev-test/deeplake-test')"...

This commit solves this specific error, but I think a larger issue is that we have a catch all except which always reraises the `S3GetError(err)` exception which then seems to...

Hi @farizrahman4u and @AbhinavTuli, I did some minor changes to fix the incorrect and ignored type-hints in the `s3.py` file. Do you want to look again or can we merge?

It does not seem like the failing tests are related to my changes? One of the failing tests is due to the deeplake `__vrsion__` string and the other seems to...

Does not seem to work for me on master either: ``` In [6]: deeplake.__version__ Out[6]: '3.1.1' In [8]: deeplake.__file__ Out[8]: '/home/daniel/src/Hub/deeplake/__init__.py' In [10]: !cd /home/daniel/src/Hub/deeplake/ && git log -n1 commit...