vaultwarden
vaultwarden copied to clipboard
dani-garcia
Fix #3624: fix manager permission within groups
Fix #3624 by checking if the user is member of a group that has access to the collection.
What if a Manager is member of a group with access to all collections?
you are right, we lack something since in this case the manager cannot edit the collection. I'm looking into it, thanks =)
@stefan0xC This d282b32d79dea870a54f7020a764b277702c4e54 should do the job.
It has to be checked first. Did not had time yet to validate. Working on other issues when i have the time.
@matlink, could you rebase and address the items mentioned by @stefan0xC? Looks ok for the rest of it i think.
@BlackDex @stefan0xC I've made the changes you requested and rebased. Needs further testing ;)
I've taken the liberty to create a PR of my own https://github.com/matlink/vaultwarden/pull/1
And, it needs a rebase of course. I tested it btw, including my suggestion, that seems to work fine.
Hey Guys, I don't want to put pressure on you people, but do you think we can nudge this one over the finish line? I would literally send you pizza :))))
So I just need to rebase?
@matlink no see my request. And a rebase too of course.
@BlackDex I've applied you suggestion. it looks like the rebase went well, no conflict. Keep me in touch if needed. Cheers,
@BlackDex I've applied you suggestion. it looks like the rebase went well, no conflict. Keep me in touch if needed. Cheers,
@matlink well, a small item. The code isn't formatted correctly.
Run a cargo fmt and that should be fixed.
@matlink well, a small item. The code isn't formatted correctly. Run a
cargo fmtand that should be fixed.
Done.
Hey, can this be merged now? The issue seems to be resolved to everybody's satisfaction. If testing is needed I would volunteer.