vaultwarden icon indicating copy to clipboard operation
vaultwarden copied to clipboard

Published 20 hours ago • verified publisher icon dani-garcia

Remove patched multer-rs

Open manofthepeace opened this issue 2 years ago • 4 comments

Seems like the fix was merged into 2022.10.0: https://github.com/bitwarden/mobile/releases/tag/v2022.10.0. Which is few months old now, so I think it is safe to remvove the workarounds

cc @BlackDex

manofthepeace avatar Dec 09 '22 17:12 manofthepeace

We want to wait with this until next year, and at least after a newer release with this patched version included. The reason is that we want to give late adapters to newer versions a bit more time.

But thanks for the PR. We can leave it open until we want to remove it, but that will probably mean you need to perform some re-bases in the meantime.

BlackDex avatar Dec 09 '22 17:12 BlackDex

No problem, just did not want it to be forgotten.

I'll leave it open and do the rebase when the times comes when you will want this merged.

manofthepeace avatar Dec 09 '22 17:12 manofthepeace

@manofthepeace from my point of view this PR is allowed to be merged now. We have a new release with this patch. And i think all is fine right now. So merging this into the testing images would be good.

So if you can re-base, @dani-garcia can merge this :).

BlackDex avatar Dec 29 '22 12:12 BlackDex

Rebase done.

manofthepeace avatar Dec 29 '22 17:12 manofthepeace