Dan Gershony

Results 91 comments of Dan Gershony

There should be a stack trace in the node.txt file This is not the stack trace it's the async provider output

The PR #1486 is closed but is still valid and can be used when we come to implement this task.

**This is actually by design.** Notice we mark the flag InsufficientHeaderInformation to true, this means we do not have enough information to validate the header and it will be put...

I would not mix checkpoints with AssumedValid for the reason you specified (and to be conservative, we don't know what vulnerabilities we might introduce by mixing AV with PH) and...

I am not sure I follow, are you referring to the BlockRepository?

Ah I see it's rewind data that is bulking up your disk. Did you consider keeping rewind data only till last checkpoint? Though , we don't have checkpoints implemented yet...

![](https://github.trello.services/images/mini-trello-icon.png) [[Consensus] Cleaning old rewind data](https://trello.com/c/KQdxAt7R/79-consensus-cleaning-old-rewind-data)

Hmmm ok I will have a look at this, we are upgrading protocol version for PH so it might cause ripple effects, but we should actually not enable witness unless...

Probably the fix here should be to separate the services and make it per network (same like the refactor coming for NetwworkProtocol enum).

`if 'application/json' in kind:` seems more correct in anycase