FixTweet icon indicating copy to clipboard operation
FixTweet copied to clipboard

Longer text cutting off with embeds

Open cobrabr opened this issue 2 years ago • 1 comments

Example: https://twitter.com/NoLieWithBTC/status/1569451415843774466

image

image

cobrabr avatar Sep 13 '22 21:09 cobrabr

We limit the amount of text that can be displayed in our embeds because our embeds work differently from Discord's (because Discord Twitter embeds tap into bot rich embeds while we can't). I'm not 100% on the hard limit, but we cap it at 200 because some Tweets above that have broken. There are definitely improvements to be made, like using ellipsis instead of just cutting off the text, etc

dangeredwolf avatar Sep 16 '22 06:09 dangeredwolf

I forgot to update this issue as I've introduced as good of a fix as I could

  • It will now show up to Discord's maximum of 256 characters in the author text field (even 257 characters will break embed)
  • If it exceeds 256 characters, it is truncated with an ellipsis so you know there is more to it

Actually, these fixes were introduced a while ago, but I only increased it from 250 to 256 characters now (I forgot to run experiments to see the proper maximum until now)

dangeredwolf avatar Sep 12 '23 10:09 dangeredwolf

Thanks @dangeredwolf, appreciate the heads up!

cobrabr avatar Sep 12 '23 15:09 cobrabr