danger-js icon indicating copy to clipboard operation
danger-js copied to clipboard

Use GitLab project ID instead of project name

Open farabi opened this issue 5 years ago • 5 comments

#969 Here i added an environment variable for gitlab project id called DANGER_GITLAB_PROJECT_ID Also added some doc about that. and updated GitlabAPI unit tests. Project name will be used if project ID is not defined (so no breaking changes).

farabi avatar Feb 13 '20 09:02 farabi

Why undo the project will to project may change?

orta avatar Mar 12 '20 14:03 orta

@orta Actually i undid the change because the build has failed after updating the readm as you suggested. I think there is an issue on the CI.

farabi avatar Mar 12 '20 16:03 farabi

I think this might have been done in #1002 too 👍

orta avatar Mar 14 '20 10:03 orta

Hi! I'm just getting started with Danger... on gitlab.com :( Is there a summary of what's blocking this PR? or anything I can do to help?

AnthonyMastrean avatar Apr 02 '20 14:04 AnthonyMastrean

Can we not to support ID and project name as Gitlab actually does?

ivankatliarchuk avatar Oct 01 '22 08:10 ivankatliarchuk