Working with two-way authentication in custom Gitlab server

[skyway777]

Before this PR, DangerJS was supporting only NODE_EXTRA_CA_CERTS env-variable to set CA certificates.

In my case, I need to use also my SSL Key and my SSL Certificate to connect to Gitlab Api.

When reading node-gitlab docs https://github.com/jdalrymple/node-gitlab I've found only way to do this as using custom requester (requester prop in options)

So, I've made my own KyRequestor realization with supporting of GITLAB_SSL_KEY and GITLAB_SSL_CERT env-variables.

[skyway777]

Maybe there is better way to do it?

[DangerCI]

	Warnings
:warning:	Could not get info from npm on custom-node-gitlab-requester

New dependencies added: custom-node-gitlab-requester.

Generated by :no_entry_sign: dangerJS against 5a1a73ddc3ae282834e7c5476836563b4557882e

[ludakhris]

I'm curious whats up with this PR, I'm having a similar issue it seems like with a gitlab self hosted instance that has two way auth.

[skyway777]

@ludakhris I cannot check if it does work now, since I don't have access to the GitLab instance for which I've created this PR anymore. But if you need this, you can build my fork of DangerJS. It depends on my custom custom-node-gitlab-requester, which also required building.

[Jimimaku]

Vor dieser PR unterstützte DangerJS nur NODE_EXTRA_CA_CERTS env-Variable zum Setzen von CA-Zertifikaten.

In meinem Fall muss ich auch meinen SSL-Schlüssel und mein SSL-Zertifikat verwenden, um eine Verbindung zur Gitlab-API herzustellen.

Beim Lesen von node-gitlab-Dokumentenhttps://github.com/jdalrymple/node-gitlabhabe ich nur einen Weg gefunden, dies als benutzerdefinierten Anforderer zu tun (Requester prop in Optionen)

Also habe ich meine eigene KyRequestor-Realisierung mit Unterstützung von GITLAB_SSL_KEY und GITLAB_SSL_CERT env-Variablen gemacht.

[Jimimaku]

Warnings ⚠️ Could not get info from npm on custom-node-gitlab-requester New dependencies added: custom-node-gitlab-requester.

Generated by 🚫 dangerJS against 5a1a73d

[Jimimaku]

@ludakhris I cannot check if it does work now, since I don't have access to the GitLab instance for which I've created this PR anymore. But if you need this, you can build my fork of DangerJS. It depends on my custom custom-node-gitlab-requester, which also required building.

[Jimimaku]

Warnings ⚠️ Could not get info from npm on custom-node-gitlab-requester New dependencies added: custom-node-gitlab-requester.

Generated by 🚫 dangerJS against 5a1a73d

[fbartho]

@Jimimaku you're duplicating other people's comments. Please stop this.

[glensc]

@Jimimaku you're duplicating other people's comments. Please stop this.

We believe Jimimaku was affected by some malware. his comments should be marked as hidden.